-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert resume pdfs to images #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small optimizations for dockerfiles:
Add the run steps for mkdir and library installations at the very start, since those actions can probably be cached before any file changes.
Add /tmp to dockerignore to prevent local tmp files being sent over.
Also don't forget to add the new env var into staging and prod configs.
30e9023
to
8a92432
Compare
Summary of Changes
PDFs sent to the #resumes channel will be converted into images automatically by Codey.
TODOs Before Merging
RESUME_CHANNEL_ID
(see below)Testing Notes
RESUME_CHANNEL_ID
variable to yourconfig.json
; this is the channel where the resumes are sent (in this case it will be #resumes)Screenshots
Nothing happens if no attachment is sent, so the screenshot for the case where a resume pdf is attached is shown below: